Skip to content

Fixed LS stops working after OS sleep/wakeup cycle #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fixed LS stops working after OS sleep/wakeup cycle #1021

merged 1 commit into from
Jun 7, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

This PR should fix the unresponsive language feature after waking up the OS from sleep.

Change description

Theia does not fire an event when the connection to the plugin server proxy closes. Theia also does not fire an event if the hosted plugins have been re-loaded. This PR adds hooks for such events, and wires in the lifecycle of the LS to the new events exposed from the hosted plugins.

Other information

Steps to verify:

  • Start IDE2,
  • Verify LS is functional,
  • Put the OS into sleep (I do not know if it works on Windows/Linux, but it's reliable on macOS),
  • Wake up the OS,
  • The LS must work (try the content assist)

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos requested review from fstasi and per1234 June 3, 2022 11:34
ubidefeo
ubidefeo approved these changes Jun 6, 2022
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works
I have first used RC6 to make sure that upon sleep (on Mac) it would fail to trigger code assist and then installed this build to do the same.
LGTM

fstasi
fstasi approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever solution! should we propose this to theia? @kittaakos

@kittaakos
Copy link
Contributor Author

should we propose this to theia? @kittaakos

I did: eclipse-theia/theia#11252. No interest. 🦗

@kittaakos kittaakos merged commit d780961 into main Jun 7, 2022
@kittaakos kittaakos deleted the zube-#10912 branch June 7, 2022 08:31
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 7, 2022
@per1234 per1234 mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

@ubidefeo ubidefeo ubidefeo approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kittaakos @fstasi @ubidefeo @per1234